feat: remove release_paid_features_tagging feature flag by jacquesikot · Pull Request #41123 · appsmithorg/appsmith

jacquesikot · 2025-07-22T05:32:51Z

Summary

This PR removes the release_paid_features_tagging feature flag and enables premium tagging for paid datasource features by default.

Changes Made

Files Modified

app/client/src/ce/entities/FeatureFlag.ts - Removed feature flag definition
app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx - Removed feature flag usage

Detailed Changes

Removed feature flag definition:
- Removed release_paid_features_tagging from FEATURE_FLAG object
- Removed corresponding default value from DEFAULT_FEATURE_FLAG_VALUE
Updated DataSidePane component:
- Removed useFeatureFlag(FEATURE_FLAG.release_paid_features_tagging) hook
- Removed conditional check if (!isPaidFeaturesTaggingEnabled) return false;
- Updated shouldShowPremiumTag function to always evaluate premium tag logic
- Cleaned up dependency array in useMemo

Impact

Premium tags for paid datasource features will now be always visible when applicable
Removes the feature flag gating mechanism that was previously controlling this behavior
Simplifies the codebase by removing conditional logic around premium tagging

Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE, @tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/16435603085
Commit: 2db1a73
Cypress dashboard.
Tags: @tag.Sanity, @tag.IDE, @tag.Datasource
Spec:

Tue, 22 Jul 2025 06:41:49 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Refactor
- Removed the feature flag for paid features tagging and all related logic from the application.

… DataSidePane

coderabbitai · 2025-07-22T05:32:59Z

Walkthrough

The changes remove the release_paid_features_tagging feature flag from the codebase. This involves deleting its definition and default value, as well as eliminating all related conditional logic and state references in the data side pane component.

Changes

File(s)	Change Summary
app/client/src/ce/entities/FeatureFlag.ts	Removed `release_paid_features_tagging` from feature flag constants and default values.
app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx	Removed use of `release_paid_features_tagging` flag and associated state/logic from the component.

Estimated code review effort

1 (~2 minutes)

Poem

A flag once waved for premium flair,
Now gone—no trace, just cleaner air.
Code grows lean, the clutter fades,
Simpler paths through editor glades.
Cheers to flags that served their time,
And tidy code, so pure, sublime!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11a5a96 and 2db1a73.

📒 Files selected for processing (2)

app/client/src/ce/entities/FeatureFlag.ts (0 hunks)
app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx (1 hunks)

🧠 Learnings (2)

📓 Common learnings

Learnt from: abhvsn
PR: appsmithorg/appsmith#39171
File: app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/FeatureFlagServiceCEImpl.java:42-44
Timestamp: 2025-02-24T05:59:14.021Z
Learning: The reactive transition for helper methods consuming @FeatureFlagged annotations will be handled in a separate PR to maintain focused changes and proper separation of concerns.

Learnt from: brayn003
PR: appsmithorg/appsmith#38171
File: app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx:1-14
Timestamp: 2024-12-15T17:45:48.303Z
Learning: In `app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx`, the feature flag check is performed at a higher level, so it's acceptable to have `isGitProtectedFeatureLicensed={false}` in this component.

Learnt from: albinAppsmith
PR: appsmithorg/appsmith#0
File: :0-0
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The tab click functionality in the `FileTabs` component should work independently of the `release_ide_tabs_revamp_enabled` feature flag to ensure stability.

Learnt from: saiprabhu-dandanayak
PR: appsmithorg/appsmith#33911
File: app/client/src/api/TemplatesApi.ts:0-0
Timestamp: 2024-07-26T21:12:57.228Z
Learning: User saiprabhu-dandanayak has confirmed the removal of the `any` type in the TypeScript code for better type safety in the `TemplatesApi.ts` file.

Learnt from: saiprabhu-dandanayak
PR: appsmithorg/appsmith#33911
File: app/client/src/api/TemplatesApi.ts:0-0
Timestamp: 2024-10-08T15:32:39.374Z
Learning: User saiprabhu-dandanayak has confirmed the removal of the `any` type in the TypeScript code for better type safety in the `TemplatesApi.ts` file.

Learnt from: sneha122
PR: appsmithorg/appsmith#30012
File: app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx:679-682
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The user `sneha122` has confirmed the resolution of the feedback regarding the redundancy of `|| false` in the `_.get` expression within the `RestAPIDatasourceForm.tsx` file.

Learnt from: sneha122
PR: appsmithorg/appsmith#30012
File: app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx:679-682
Timestamp: 2024-10-08T15:32:34.115Z
Learning: The user `sneha122` has confirmed the resolution of the feedback regarding the redundancy of `|| false` in the `_.get` expression within the `RestAPIDatasourceForm.tsx` file.

Learnt from: dipyamanbiswas07
PR: appsmithorg/appsmith#29282
File: app/client/cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js:11-17
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The user has clarified that intercepts are called in end-to-end tests, and therefore resetting the feature flag in an `afterEach` hook is not required in their test setup.

Learnt from: ashit-rath
PR: appsmithorg/appsmith#37912
File: app/client/src/git/components/QuickActions/helpers.ts:22-25
Timestamp: 2024-12-03T10:13:43.282Z
Learning: In `app/client/src/git/components/QuickActions/helpers.ts`, the unnecessary `@ts-ignore` comments will be removed in future PRs.

app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx (10)

Learnt from: brayn003
PR: #38171
File: app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx:1-14
Timestamp: 2024-12-15T17:45:48.303Z
Learning: In app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx, the feature flag check is performed at a higher level, so it's acceptable to have isGitProtectedFeatureLicensed={false} in this component.

Learnt from: albinAppsmith
PR: appsmithorg/appsmith#0
File: :0-0
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The tab click functionality in the FileTabs component should work independently of the release_ide_tabs_revamp_enabled feature flag to ensure stability.

Learnt from: brayn003
PR: #38088
File: app/client/src/git/components/GitQuickActions/BranchButton/index.tsx:72-74
Timestamp: 2024-12-11T08:33:24.352Z
Learning: In the 'BranchButton' component in 'app/client/src/git/components/GitQuickActions/BranchButton/index.tsx' (TypeScript, React), the useEffect hook that checks for label ellipsis does not need to include currentBranch in its dependency array.

Learnt from: ashit-rath
PR: #37912
File: app/client/src/git/components/QuickActions/helpers.ts:22-25
Timestamp: 2024-12-03T10:13:43.282Z
Learning: In app/client/src/git/components/QuickActions/helpers.ts, the unnecessary @ts-ignore comments will be removed in future PRs.

Learnt from: saiprabhu-dandanayak
PR: #33911
File: app/client/src/api/TemplatesApi.ts:0-0
Timestamp: 2024-07-26T21:12:57.228Z
Learning: User saiprabhu-dandanayak has confirmed the removal of the any type in the TypeScript code for better type safety in the TemplatesApi.ts file.

Learnt from: saiprabhu-dandanayak
PR: #33911
File: app/client/src/api/TemplatesApi.ts:0-0
Timestamp: 2024-10-08T15:32:39.374Z
Learning: User saiprabhu-dandanayak has confirmed the removal of the any type in the TypeScript code for better type safety in the TemplatesApi.ts file.

Learnt from: abhvsn
PR: #39171
File: app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/FeatureFlagServiceCEImpl.java:42-44
Timestamp: 2025-02-24T05:59:14.021Z
Learning: The reactive transition for helper methods consuming @FeatureFlagged annotations will be handled in a separate PR to maintain focused changes and proper separation of concerns.

Learnt from: ankitakinger
PR: #29965
File: app/client/src/utils/storage.ts:129-129
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The migrateAppIdToEditorId function in app/client/src/utils/storage.ts is intended to be called only when appId is present and editorId is not in the payload. This context should be considered in future reviews related to this function.

Learnt from: ankitakinger
PR: #29965
File: app/client/src/utils/storage.ts:129-129
Timestamp: 2024-10-08T15:32:34.115Z
Learning: The migrateAppIdToEditorId function in app/client/src/utils/storage.ts is intended to be called only when appId is present and editorId is not in the payload. This context should be considered in future reviews related to this function.

Learnt from: AmanAgarwal041
PR: #38110
File: app/client/src/utils/ProductRamps/RampsControlList.ts:36-36
Timestamp: 2024-12-16T17:34:50.458Z
Learning: When adding a new feature to RAMP_NAME in app/client/src/utils/ProductRamps/RampsControlList.ts, adding it to PRODUCT_RAMPS_LIST may not be necessary.

💤 Files with no reviewable changes (1)

app/client/src/ce/entities/FeatureFlag.ts

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: abhvsn
PR: appsmithorg/appsmith#39171
File: app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/FeatureFlagServiceCEImpl.java:42-44
Timestamp: 2025-02-24T05:59:14.021Z
Learning: The reactive transition for helper methods consuming @FeatureFlagged annotations will be handled in a separate PR to maintain focused changes and proper separation of concerns.

Learnt from: brayn003
PR: appsmithorg/appsmith#38171
File: app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx:1-14
Timestamp: 2024-12-15T17:45:48.303Z
Learning: In `app/client/src/git/components/DefaultBranch/DefaultBranchCE.tsx`, the feature flag check is performed at a higher level, so it's acceptable to have `isGitProtectedFeatureLicensed={false}` in this component.

Learnt from: albinAppsmith
PR: appsmithorg/appsmith#0
File: :0-0
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The tab click functionality in the `FileTabs` component should work independently of the `release_ide_tabs_revamp_enabled` feature flag to ensure stability.

Learnt from: saiprabhu-dandanayak
PR: appsmithorg/appsmith#33911
File: app/client/src/api/TemplatesApi.ts:0-0
Timestamp: 2024-07-26T21:12:57.228Z
Learning: User saiprabhu-dandanayak has confirmed the removal of the `any` type in the TypeScript code for better type safety in the `TemplatesApi.ts` file.

Learnt from: saiprabhu-dandanayak
PR: appsmithorg/appsmith#33911
File: app/client/src/api/TemplatesApi.ts:0-0
Timestamp: 2024-10-08T15:32:39.374Z
Learning: User saiprabhu-dandanayak has confirmed the removal of the `any` type in the TypeScript code for better type safety in the `TemplatesApi.ts` file.

Learnt from: sneha122
PR: appsmithorg/appsmith#30012
File: app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx:679-682
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The user `sneha122` has confirmed the resolution of the feedback regarding the redundancy of `|| false` in the `_.get` expression within the `RestAPIDatasourceForm.tsx` file.

Learnt from: sneha122
PR: appsmithorg/appsmith#30012
File: app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx:679-682
Timestamp: 2024-10-08T15:32:34.115Z
Learning: The user `sneha122` has confirmed the resolution of the feedback regarding the redundancy of `|| false` in the `_.get` expression within the `RestAPIDatasourceForm.tsx` file.

Learnt from: dipyamanbiswas07
PR: appsmithorg/appsmith#29282
File: app/client/cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js:11-17
Timestamp: 2024-07-26T21:12:57.228Z
Learning: The user has clarified that intercepts are called in end-to-end tests, and therefore resetting the feature flag in an `afterEach` hook is not required in their test setup.

Learnt from: ashit-rath
PR: appsmithorg/appsmith#37912
File: app/client/src/git/components/QuickActions/helpers.ts:22-25
Timestamp: 2024-12-03T10:13:43.282Z
Learning: In `app/client/src/git/components/QuickActions/helpers.ts`, the unnecessary `@ts-ignore` comments will be removed in future PRs.